small ScriptKit tweak: create new NSConnection rather than using +defaultConnection
Updated 1 year, 7 months ago
| Eric Wasylishen | Reviewers | ||
| EtoileCore | |||
| TheRaven | |||
| None | Etoile trunk (etoile/trunk/Etoile) | ||
ScriptKit was using [NSConnection defaultConnection]. If an app tries to use defaultConnection for something else, this will break scripting for that app. I changed ScriptKit to create its own NSConnection using +alloc and -init.
Checked that OverlayShelf still works.
Looks good. Minor cosmetic tweak then commit.
-
/Frameworks/ScriptKit/ScriptCenter.m (Diff revision 1) -
Keep the blank line here please.
-
/Frameworks/ScriptKit/ScriptCenter.m (Diff revision 1) -
I prefer (nil == theConnection) here. C lets you treat everything as if it were a boolean, but it's clearer if you explicitly state the text. It will generate the same code and is slightly more readable.