Review Board

1.0

EoileThread bug fixes.

Updated 1 year, 9 months ago

David Chisnall Reviewers
EtoileCore
None Étoilé Stable 
ETThreadTest is now moved into examples in trunk, so it's gone here.

Fixed random stack corruption caused by NSInvocation not having the same undocumented behaviour as on OS X (doesn't work with ffcall - added a warning to this effect).

Fixed race condition on dealloc which could cause deadlock.

Moved retain/release into the proxy.
Run test suite created by Eric.
Ship it!
Quentin Mathé
Posted 1 year, 9 months ago (December 3rd, 2008, 3:54 a.m.)
Looks good to me :-) EtoileThreadExample runs fine on my Ubuntu install too. Just add a bit more spacing and bump the version number before merging into stable.
A blank line would be welcome before @interface
A blank line would be welcome before @implementation
A blank line would be welcome before @interface
A blank line would be welcome before @implementation
Split the log statement on two lines to respect the max character width limitation. I think the limitation can be stretched from 80 to 120 chars time to time, but in this case it looks the line width is greater than 120 chars.

Bump the version to 0.1.1, so we don't have to do it later. Also update it in the README file if needed.